Skip to content

test: moves the fixture update spec file#29801

Merged
christopherferreira9 merged 1 commit into
mainfrom
cferreira/move-fixture-validation-spec
May 6, 2026
Merged

test: moves the fixture update spec file#29801
christopherferreira9 merged 1 commit into
mainfrom
cferreira/move-fixture-validation-spec

Conversation

@christopherferreira9
Copy link
Copy Markdown
Contributor

@christopherferreira9 christopherferreira9 commented May 6, 2026 •
edited by cursor Bot
Loading

Description

This PR moves the default fixture change detection spec from regression into smoke

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk: this only updates CI/workflow and a helper script to reference the relocated fixture validation test path, with no production code changes.

Overview
The fixture update workflow and local update-e2e-fixture.sh script now run tests/smoke/fixtures/fixture-validation.spec.ts instead of the prior tests/regression/... location, aligning automation with the test’s new suite placement.

Reviewed by Cursor Bugbot for commit 6358611. Bugbot is set up for automated code reviews on this repo. Configure here.

@christopherferreira9 christopherferreira9 requested a review from a team as a code owner May 6, 2026 15:00
@christopherferreira9 christopherferreira9 added team-qa QA team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 6, 2026
@jvbriones jvbriones removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changed files are E2E infrastructure-related:

  • .github/workflows/update-e2e-fixtures.yml (CI workflow)
  • tests/scripts/update-e2e-fixture.sh (fixture generation script)
  • tests/smoke/fixtures/fixture-validation.spec.ts (fixture validation test)

Although no application code was modified, these changes directly affect the E2E testing pipeline and fixture generation/validation logic. Fixtures are foundational to nearly all smoke tests (wallet state, accounts, networks, balances, etc.). Any regression in fixture creation or validation could cause widespread false positives/negatives across test suites.

Because fixture updates can impact:

  • Account state (SmokeAccounts, SmokeIdentity, SmokeWalletPlatform)
  • Network configuration (SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeMultiChainAPI)
  • Transaction flows (SmokeConfirmations, SmokeSwap, SmokeStake, SmokeMoney, SmokePerps, SmokePredictions)
  • Browser and Snaps initialization state (SmokeBrowser, SmokeSnaps)
  • Onboarding/login-related flows (SmokeSeedlessOnboarding)

This is classified as HIGH risk for test reliability (not product logic), and the safest validation strategy is to run the full E2E smoke matrix to ensure fixtures remain compatible with all flows.

Skipping subsets would risk missing fixture-dependent breakages in less frequently used flows (e.g., Snaps, Perps, MultiChainAPI).

Performance Test Selection:
No application source code, UI components, controllers, Engine logic, or performance-sensitive flows were modified. Changes are limited to CI workflow and E2E fixture scripts/tests. Therefore, no risk to runtime performance, rendering, startup time, or network performance. Performance tests are not required.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@christopherferreira9 christopherferreira9 added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 34f3d4c May 6, 2026
179 of 183 checks passed
@christopherferreira9 christopherferreira9 deleted the cferreira/move-fixture-validation-spec branch May 6, 2026 16:29
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.77.0 Issue or pull request that will be included in release 7.77.0 label May 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jvbriones jvbriones jvbriones approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.77.0 Issue or pull request that will be included in release 7.77.0 size-XS team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherferreira9 @jvbriones